Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up generator settings #1273

Open
2 of 4 tasks
srs-bsns opened this issue Aug 13, 2018 · 2 comments
Open
2 of 4 tasks

Clean up generator settings #1273

srs-bsns opened this issue Aug 13, 2018 · 2 comments
Labels

Comments

@srs-bsns
Copy link
Member

srs-bsns commented Aug 13, 2018

Audit generator settings and:

  • Remove settings that will never be used. (eg seaLevel)
  • Assess and adjust defaults where necessary. (eg useRavines = false)
  • Implement currently unimplemented settings.
  • Remove all config settings that an equivelent generator setting replaces.
@srs-bsns srs-bsns added the 1.12 label Aug 13, 2018
srs-bsns added a commit that referenced this issue Jan 2, 2019
- Migrates the main config out of the API and back to the
  implementation side of the mod where it belongs. This creates a few
  more minor instances of the API referencing implementaion.
- removes all deprecated settings that were moved to generator settings
- solves config syncing issues with the config GUI
- marks some settings as requiring a restart
- removed debug settings for disabling surfacing and decorations
  globally and moved them to system properties that can be used by
  passing -Drtg.disableDecorations or -Drtg.disableSurfaces as JVM
  arguments
- removed scenic lake settings and hardcoded them in BiomeAnalyser
- Migrated the GUI config classes to inner classes of the main config
  class
- added en_us lang keys for all config elements

Partially related changes:
- slight refactoring of client GUI classes
- migrate DecoUtil functionality to the few places it's members were
  used and removed the util class

Addresses parts of #1273
closes #1301

Signed-off-by: srs-bsns <[email protected]>
@whichonespink44
Copy link
Member

The remaining items in this issue are still worth doing, but can probably wait until we release for 1.12

@srs-bsns
Copy link
Member Author

In the GenLayer system I am making seaLevel is completely hardcoded, so that setting won't exist soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants