Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency for RTG needs to be fixed #174

Open
srs-bsns opened this issue Jan 30, 2017 · 0 comments
Open

Dependency for RTG needs to be fixed #174

srs-bsns opened this issue Jan 30, 2017 · 0 comments

Comments

@srs-bsns
Copy link
Member

dependencies = "required-after:Forge@[" + ModInfo.MCF_MINVER + "," + ModInfo.MCF_MAXVER + ");required-before:RTG@[" + ModInfo.RTG_MINVER + "," + ModInfo.RTG_MAXVER + ")",
acceptableRemoteVersions = "*"

    dependencies = "required-after:Forge@[" + ModInfo.MCF_MINVER + "," + ModInfo.MCF_MAXVER + ");required-before:RTG@[" + ModInfo.RTG_MINVER + "," + ModInfo.RTG_MAXVER + ")",
    acceptableRemoteVersions = "*"

  1. The dependency on RTG needs to be such that APL can load on the client without also loading RTG (dedicated server play).
  2. acceptableRemoteVersions = "*" is innappropriate for APL, because it is required on the client.
  3. APL loading server-side needs to verify the version of the RTG API.
  4. APL loading client-side needs to verify that it is the same version of APL running server-side (this check is, AFAIK, automatic by default upon connect).

Using after: with a correct version range is probably the best solution. The version of the RTG API should adhere to SemVer and the version range can block anything above the current major version. (ie: after:RTG-API@[1.2.3, 2.0.0))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant