Create Match Information Screen #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleich
suggested changes
Apr 22, 2020
There was a problem hiding this comment.
- Shared preferences shouldn't be used for scouting information. Only for settings.
- Simply setting the constructor as const doesn't make the widget const.
- Match number text field should show the number keyboard.
Don't work on these now, we will talk about them more at the meeting tonight.
gleich
force-pushed
the
match-info-screen
branch
from
ab2e3b9 to
a1f0769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16.
Looks pretty much exactly like the Figma drawing. I did leave a commented section of code in main.dart in case you want to preview the screen easily on your device. Designed tablet-first.