Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchiveWidget restore files -> only certain ones #129

Open
gperciva opened this issue Oct 17, 2016 · 4 comments
Open

ArchiveWidget restore files -> only certain ones #129

gperciva opened this issue Oct 17, 2016 · 4 comments
Assignees
Milestone

Comments

@gperciva
Copy link
Member

ArchiveWidget

  • right-click, select "Restore files(s)"
  • the RestoreDialog says "Restore archive xyz contents to original locations..." and does not clarify that only the select file(s) will be restored.

I can tackle this in the next few days, but I thought I should record the problem.

@gperciva gperciva self-assigned this Oct 17, 2016
@shinnok
Copy link
Contributor

shinnok commented May 24, 2017

Do you have something stashed for this? I'm about to pick on it and I don't want to duplicate efforts. :-)

@gperciva
Copy link
Member Author

Hmm, apparently not. That was around the time that I did a lot of work on the scrypt testing and debian packaging, so I guess this one slipped my mind.

@gperciva gperciva removed their assignment May 24, 2017
@shinnok shinnok self-assigned this May 27, 2017
@gperciva
Copy link
Member Author

Looks great for restoring a specific file, thanks!

However, if I'm trying to restore an archive and the GUI hasn't loaded the full file list, it displays nothing in the box. In the "Archives" screen, I need to:

  1. click on the "i" to load the file list.
  2. click on the "restore this" icon.

This applies to archives created within the GUI, in addition to archives created from the command-line.

@gperciva
Copy link
Member Author

Update: it looks like if I load the file list, then quit the app and re-start it, it has the file list cached.

#152 proposes one way to address this: if we don't have the archive contents, don't display the file list box. This should only affect restoring a whole archive.

An alternative solution would be to wait until the file list is loaded before allowing us to restore an archive, but that would added a delay, which would degrade the user experience during this interactive operation. Particularly for users with huge archives (#149 (comment): 500,000 files?! wow!).

@shinnok shinnok added this to the v1.0 milestone Jun 12, 2017
@shinnok shinnok modified the milestones: v1.1, v1.0 Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants