Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming issues #25

Open
Erimus-Koo opened this issue Dec 3, 2023 · 10 comments
Open

Naming issues #25

Erimus-Koo opened this issue Dec 3, 2023 · 10 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Erimus-Koo
Copy link

I appreciate your work, but I encountered folder and naming issues while using the emojis.

For example,

  1. Man in Tuxedo is in the folder "People with activities", and Woman in Tuxedo is in the "People with professions".
  2. In the folder "People with activities", no genders have the prefix "person". In the "People with professions" folder, no gender has a prefix.

I'm trying to write a component for randomly choosing emojis with certain keywords, like "{gender}in Tuxedo{skin}", and then meet the naming problem.

Using folders to guide emoji selection is simple and clear, but I've noticed that in microsoft/fluentui-emoji, there are some metadata. json that provides more details for searching. Could these metadata files be merged into this project?

@malte9799
Copy link

You can take a look at my repo where I combine the standard Fluent emoji and animated emojis with standard naming schemes and complete metadata.json

@Tarikul-Islam-Anik Tarikul-Islam-Anik added the help wanted Extra attention is needed label Dec 3, 2023
@Tarikul-Islam-Anik
Copy link
Owner

Certainly, addressing the folder and naming inconsistencies you've highlighted with emojis is an important improvement. You've rightly pointed out the differences in folder organization and naming conventions across different gender-related emojis, which can create challenges in component development when seeking specific emojis based on keywords.

Regarding incorporating metadata files similar to those found in microsoft/fluentui-emoji, it's indeed a promising approach to enhance search capabilities and provide more comprehensive details for emoji selection. However, merging these metadata files into our project might present a breaking change for users who are currently relying on the existing structure.

I understand the significance of this improvement and will explore feasible solutions to harmonize the folder structure and naming conventions without causing disruptions for existing users. It might take some time to implement these changes thoughtfully while minimizing the impact on ongoing usage.

Rest assured, I'll delve deeper into this matter and strive to find a solution that enhances the search functionality while ensuring a smooth transition for our user base. Your input is greatly appreciated, and I'll keep you updated on the progress. Thank you for bringing this to our attention.

@Tarikul-Islam-Anik
Copy link
Owner

After a second thought I've decided to implement the same folder and file structure like microsoft/fluentui-emoji repository.

If you encounter any more issues or have further suggestions, please don't hesitate to share them with me. Your contributions help me refine and improve this project for everyone.

Thank you once again for your suggestion and your support.

Best regards,
Tarikul-Islam-Anik

@Tarikul-Islam-Anik Tarikul-Islam-Anik self-assigned this Dec 3, 2023
@Erimus-Koo
Copy link
Author

That sounds great! I'm currently using your repository and will encounter some breaking changes. However, I am considering forking it and using it for a few days.

I have read the license of the fluent emoji, but I couldn't find any information about the animation version. Do you happen to know anything about that?

@Tarikul-Islam-Anik
Copy link
Owner

As far as I know, they fall under the same license.

@Erimus-Koo
Copy link
Author

Well, that sounds great.

@Erimus-Koo
Copy link
Author

And there's one more question, does the animation version has an official repository? I can not find it.

@Tarikul-Islam-Anik
Copy link
Owner

Unfortunately, there is no official repository for the animated version.

@Erimus-Koo
Copy link
Author

Animated-Fluent-Emojis/Emojis/People/Woman Construction Worker.png at master · Tarikul-Islam-Anik/Animated-Fluent-Emojis
https://github.com/Tarikul-Islam-Anik/Animated-Fluent-Emojis/blob/master/Emojis/People/Woman%20Construction%20Worker.png

Accidentally came across this, so strange.

@Tarikul-Islam-Anik
Copy link
Owner

Thanks for pointing this out. Unfortunately, there is no fix available for this emoji right now. I'll replace the file if I find the fixed version of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants