Skip to content

Commit

Permalink
v9.0.5 => Release Notes for details
Browse files Browse the repository at this point in the history
  • Loading branch information
TarekRaafat committed Apr 26, 2021
1 parent 443bb67 commit b4f4f1c
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ autoComplete.js is a simple pure vanilla Javascript library that's progressively
`JS`

```html
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/js/autoComplete.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].5/dist/js/autoComplete.min.js"></script>
```

`CSS`

```html
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/css/autoComplete.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].5/dist/css/autoComplete.min.css">
```
#### Package Manager

Expand Down
2 changes: 1 addition & 1 deletion dist/js/autoComplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@
list = createList(config);
}
config.inputField.setAttribute("aria-expanded", true);
if (config.resultsList.container) config.resultsList.container(list);
if (matches.length) {
var _loop = function _loop(index) {
var item = data.results[index];
Expand Down Expand Up @@ -232,6 +231,7 @@
config.resultsList.noResults(list, data.query);
}
}
if (config.resultsList.container) config.resultsList.container(list);
document.addEventListener("click", function (event) {
return closeList(config, event.target);
});
Expand Down
Binary file modified dist/js/autoComplete.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion dist/js/autoComplete.min.js

Large diffs are not rendered by default.

Binary file modified dist/js/autoComplete.min.js.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ <h4>mode</h4>
</div>
</footer>
</div>
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/js/autoComplete.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].5/dist/js/autoComplete.min.js"></script>
<script src="./js/index.js"></script>
</body>

Expand Down
4 changes: 2 additions & 2 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
mustache: {
data: ["../package.json", {
minVersion: "9.0",
version: "9.0.4"
version: "9.0.5"
}]
}
}
Expand All @@ -206,7 +206,7 @@
<script src="//unpkg.com/docsify-copy-code"></script>
<script src="//cdn.jsdelivr.net/npm/codeblock-iframe@latest/dist/index.min.js"></script>
<script src="//cdn.jsdelivr.net/npm/docsify-codeblock-iframe@latest/dist/index.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/js/autoComplete.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].5/dist/js/autoComplete.min.js"></script>
</body>

</html>
5 changes: 4 additions & 1 deletion docs/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ For more information on semantic versioning, please visit <http://semver.org/>.

***

### v9.0.4 ✨
### v9.0.5 ✨
- 🔧 Fixed: `resultsList.container` hierarchy comes after list rendering instead of before

### v9.0.4
- 🔧 Fixed: `resultsList.container` is removed on second input (Thanks 👍 @folknor) #206

### v9.0.3
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tarekraafat/autocomplete.js",
"version": "9.0.4",
"version": "9.0.5",
"description": "Simple autocomplete pure vanilla Javascript library.",
"keywords": [
"simple",
Expand Down
5 changes: 3 additions & 2 deletions src/controllers/listController.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ const generateList = (config, data, matches) => {
}
// Set list to opened
config.inputField.setAttribute("aria-expanded", true);
// If custom container is set pass the list
if (config.resultsList.container) config.resultsList.container(list);

// Check if there are results
if (matches.length) {
Expand Down Expand Up @@ -87,6 +85,9 @@ const generateList = (config, data, matches) => {
config.resultsList.noResults(list, data.query);
}
}
// If custom container is set pass the list
if (config.resultsList.container) config.resultsList.container(list);

/**
* @desc
* Listen for all `click` events in the document
Expand Down

0 comments on commit b4f4f1c

Please sign in to comment.