Renaming PublicKey and PrivateKey Classes

[kmy504]

Hello,

Our project currently faces a significant name collision issue. Specifically, the PublicKey class is implemented in both the MessageProtection framework and the SwiftyRSA framework. This is causing the following warning message to appear:

objc[13599]: Class PublicKey is implemented in both /System/Library/PrivateFrameworks/MessageProtection.framework/MessageProtection (0x254bf2000) and /private/var/containers/Bundle/Application/9866BA82-B322-4442-BDD8-AD39140E4AEC/Band.app/Frameworks/SwiftyRSA.framework/SwiftyRSA (0x11354e1d0). One of the two will be used. Which one is undefined.

To resolve this issue, I propose renaming the PublicKey and PrivateKey classes within the SwiftyRSA framework to SwiftyRSAPublicKey and SwiftyRSAPrivateKey, respectively. This change will address the name collision and improve code readability and maintainability.

The changes are as follows:

PublicKey -> SwiftyRSA.PublicKey
PrivateKey -> SwiftyRSA.PrivateKey
I believe these changes will positively impact the project. I appreciate your review and feedback on this matter.

Thank you.

[pc-scoop]

@kmy504 This is good update and thanks for the contribution. I'll look into how this might affect our internal usage of the framework and get back on this.

[Misantrofia]

Hello,

When is this going to be merged? I have the same collision on my project.

[kmy504]

@pc-scoop Apple has been implement same name with PublicKey. So if some project use Apple's framework like MessageProtection framework, It would be cause name collision.

So I wrapped SwiftyRSA's struct that cause name collision with SwiftyRsa enum extension to look like a namespace.

@Misantrofia Use my forked repository before merge. :)