[BUGFIX] NPE in Index Queue module when no site is selected #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multi site setups a null pointer exception is thrown when opening the Index Queue TYPO3 module without having a solr-enabled page selected in the page tree. The NPE is thrown in `::initializeAction()` before the original handling of the "no site selected" case in `::indexAction()`. Fixes: 3ea2713 ("[TASK:BP:11.6] Consider queue initialization status")
dkd-kaehm
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi site setups a null pointer exception is thrown when opening the Index Queue TYPO3 module without having a solr-enabled page selected in the page tree. The NPE is thrown in
::initializeAction()before the original handling of the "no site selected" case in::indexAction().Fixes: 3ea2713 ("[TASK:BP:11.6] Consider queue initialization status")
What this pr does
Brings back the existing "No site could be found." error message to the Index Queue TYPO3 module.
How to test
Open the Index Queue TYPO3 module in an PHP 8.2, TYPO3 v11.5.41, EXT:solr v11.6.0 installation, that contains at least two sites with solr enabled. Select the root page (imaginary page with uid=0) in the page tree.