Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#62)feat/project layout modify #67

Merged
merged 20 commits into from
Jun 17, 2024
Merged

(#62)feat/project layout modify #67

merged 20 commits into from
Jun 17, 2024

Conversation

Ajeong-Im
Copy link
Contributor

๐Ÿ“ข ๊ธฐ๋Šฅ ์„ค๋ช…

image

์—ฐ๊ฒฐ๋œ issue

์—ฐ๊ฒฐ๋œ issue๋ฅผ ์ž๋™์œผ๋กœ ๋‹ซ๊ธฐ ์œ„ํ•ด ์•„๋ž˜ {์ด์Šˆ๋„˜๋ฒ„}๋ฅผ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”.

close #{62}



๐Ÿฉท Approve ํ•˜๊ธฐ ์ „ ํ™•์ธํ•ด์ฃผ์„ธ์š”!

  • ๋ฆฌ๋ทฐ์–ด๊ฐ€ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ์‚ฌํ•ญ ์ ์–ด์ฃผ์„ธ์š”.
  • [ ]

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ ๊ทœ์น™ ์ž˜ ์ง€์ผฐ๋Š”๊ฐ€?
  • ์ถ”๊ฐ€/์ˆ˜์ •์‚ฌํ•ญ์„ ์„ค๋ช…ํ•˜์˜€๋Š”๊ฐ€?
  • ์ด์Šˆ๋„˜๋ฒ„๋ฅผ ์ ์—ˆ๋Š”๊ฐ€?
  • Approve ํ•˜๊ธฐ ์ „ ํ™•์ธ ์‚ฌํ•ญ ์ฒดํฌํ–ˆ๋Š”๊ฐ€?

Ajeong-Im and others added 14 commits May 29, 2024 22:44
@Ajeong-Im
feat: project layout ์ƒ์„ฑ
1f6dd82
@Ajeong-Im
feat: project ์ด๋ฏธ์ง€ ํŒ์—… ์ƒ์„ฑ
71f2f8b
@Ajeong-Im
usenavigate
0e8cede
@Jayjunyoung @Ajeong-Im
fix: option3 ์„ ํƒ ํ›„ option1,2 ์„ ํƒ ์‹œ ๋žœ๋”๋ง ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
e992c1d
@Jayjunyoung @Ajeong-Im
refactor: IntroSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
cd24661
@Jayjunyoung @Ajeong-Im
refactor: ExperienceSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
05d2265
@Jayjunyoung @Ajeong-Im
fix: ContactSection opion2์ผ๋•Œ ์ด๋ฆ„ ์ž…๋ ฅ ์—†์„ ์‹œ ๋žœ๋”๋ง ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
26aaaea
@Jayjunyoung @Ajeong-Im
refactor: ContactSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
232348d
@Jayjunyoung @Ajeong-Im
react-color ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ํ™œ์šฉํ•ด color ์˜ต์…˜ ์ œ๊ณต ๊ตฌํ˜„
f13768a
@Jayjunyoung @Ajeong-Im
feat: ํฌํŠธํด๋ฆฌ์˜ค ์„น์…˜ ๋ณ„ ๋ ˆ์ด์•„์›ƒ ์˜ต์…˜ ๋ฐ์ดํ„ฐ ์ €์žฅ ๊ตฌํ˜„
c7469d2
@Jayjunyoung @Ajeong-Im
feat: ํฌํŠธํด๋ฆฌ์˜ค ๋ฐ์ดํ„ฐ ์—†์„ ์‹œ ๊ธฐ๋ณธ ์˜ต์…˜๊ฐ’ ์„ค์ • ๊ตฌํ˜„
34cd003
@Jayjunyoung @Ajeong-Im
fix: skill Section ๋ ˆ์ด์•„์›ƒ ์˜ต์…˜ ์„ค์ • ์˜ค๋ฅ˜ ์ˆ˜์ • ๋ฐ ์ œ๊ฑฐ
d274792
@POL6463 @Ajeong-Im
fix: add same changes to DropAreaView
756efb3
@Ajeong-Im
feat: project layout sidebar ๋ถ„๋ฆฌ
f8c6de6
@Ajeong-Im Ajeong-Im requested review from POL6463 and Jayjunyoung June 16, 2024 16:06
@Ajeong-Im Ajeong-Im self-assigned this Jun 16, 2024
@Ajeong-Im Ajeong-Im linked an issue Jun 16, 2024 that may be closed by this pull request
[feat] project layout ๋ณ€๊ฒฝ #62
Closed
POL6463
POL6463 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@POL6463 POL6463 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@POL6463 POL6463 merged commit f9710ac into develop Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@POL6463 POL6463 POL6463 approved these changes

@Jayjunyoung Jayjunyoung Awaiting requested review from Jayjunyoung

Assignees

@Ajeong-Im Ajeong-Im

Labels
๊ธฐ๋Šฅ๊ตฌํ˜„
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] project layout ๋ณ€๊ฒฝ
3 participants
@Ajeong-Im @POL6463 @Jayjunyoung