Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#57)feat/sectionLayout #63

Merged
merged 9 commits into from
Jun 13, 2024
Merged

(#57)feat/sectionLayout #63

merged 9 commits into from
Jun 13, 2024

Conversation

Jayjunyoung
Copy link
Contributor

@Jayjunyoung Jayjunyoung commented Jun 1, 2024 •
edited
Loading

๐Ÿ“ข ๊ธฐ๋Šฅ ์„ค๋ช…

ํ•„์š”์‹œ ์‹คํ–‰๊ฒฐ๊ณผ ์Šคํฌ๋ฆฐ์ƒท ์ฒจ๋ถ€


โœ… ํฌํŠธํด๋ฆฌ์˜ค ์ž‘์„ฑ ํ›„ ์ €์žฅ ํด๋ฆญ
โœ… ์„œ๋ฒ„ ์ข…๋ฃŒ ํ›„ ๋‹ค์‹œ ๊ฐ€๋™๋˜๋„ ํ•ด๋‹น ์ด๋ฏธ์ง€์น˜๋Ÿผ ๊ฐ๊ฐ ์˜ต์…˜,๋ฐ์ดํ„ฐ ์—ฐ๋™

image

<ํฌํŠธํด๋ฆฌ์˜ค 1>

image

<ํฌํŠธํด๋ฆฌ์˜ค 2>

image

์—ฐ๊ฒฐ๋œ issue

์—ฐ๊ฒฐ๋œ issue๋ฅผ ์ž๋™์œผ๋กœ ๋‹ซ๊ธฐ ์œ„ํ•ด ์•„๋ž˜ {์ด์Šˆ๋„˜๋ฒ„}๋ฅผ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”.

close #57



๐Ÿฉท Approve ํ•˜๊ธฐ ์ „ ํ™•์ธํ•ด์ฃผ์„ธ์š”!

  • ๋ฆฌ๋ทฐ์–ด๊ฐ€ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ์‚ฌํ•ญ ์ ์–ด์ฃผ์„ธ์š”.
  • [ ]

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ ๊ทœ์น™ ์ž˜ ์ง€์ผฐ๋Š”๊ฐ€?
  • ์ถ”๊ฐ€/์ˆ˜์ •์‚ฌํ•ญ์„ ์„ค๋ช…ํ•˜์˜€๋Š”๊ฐ€?
  • ์ด์Šˆ๋„˜๋ฒ„๋ฅผ ์ ์—ˆ๋Š”๊ฐ€?
  • Approve ํ•˜๊ธฐ ์ „ ํ™•์ธ ์‚ฌํ•ญ ์ฒดํฌํ–ˆ๋Š”๊ฐ€?

@Jayjunyoung
fix: option3 ์„ ํƒ ํ›„ option1,2 ์„ ํƒ ์‹œ ๋žœ๋”๋ง ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
a292e42
@Jayjunyoung
refactor: IntroSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
fc605cc
@Jayjunyoung
refactor: ExperienceSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
d4ebc83
@Jayjunyoung
fix: ContactSection opion2์ผ๋•Œ ์ด๋ฆ„ ์ž…๋ ฅ ์—†์„ ์‹œ ๋žœ๋”๋ง ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
f529fed
@Jayjunyoung
refactor: ContactSection ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธํ™”
d86e0b7
@Jayjunyoung
react-color ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ํ™œ์šฉํ•ด color ์˜ต์…˜ ์ œ๊ณต ๊ตฌํ˜„
d27b9ff
@Jayjunyoung
feat: ํฌํŠธํด๋ฆฌ์˜ค ์„น์…˜ ๋ณ„ ๋ ˆ์ด์•„์›ƒ ์˜ต์…˜ ๋ฐ์ดํ„ฐ ์ €์žฅ ๊ตฌํ˜„
ab643cb
@Jayjunyoung
feat: ํฌํŠธํด๋ฆฌ์˜ค ๋ฐ์ดํ„ฐ ์—†์„ ์‹œ ๊ธฐ๋ณธ ์˜ต์…˜๊ฐ’ ์„ค์ • ๊ตฌํ˜„
6252a9a
@Jayjunyoung
fix: skill Section ๋ ˆ์ด์•„์›ƒ ์˜ต์…˜ ์„ค์ • ์˜ค๋ฅ˜ ์ˆ˜์ • ๋ฐ ์ œ๊ฑฐ
1822047
@Jayjunyoung Jayjunyoung requested review from POL6463 and Ajeong-Im June 1, 2024 10:44
@Jayjunyoung Jayjunyoung changed the title (#57)feat/section layout (#57)feat/sectionLayout Jun 1, 2024
POL6463
POL6463 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@POL6463 POL6463 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM์ž…๋‹ˆ๋‹ค

@POL6463 POL6463 merged commit 5c3f1a7 into develop Jun 13, 2024
@Jayjunyoung Jayjunyoung self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@POL6463 POL6463 POL6463 approved these changes

@Ajeong-Im Ajeong-Im Awaiting requested review from Ajeong-Im

Assignees

@Jayjunyoung Jayjunyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Section Layout Option ๋ฐ์ดํ„ฐ ์ €์žฅ ๋ฐ ์—ฐ๋™
2 participants
@Jayjunyoung @POL6463