Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between counts and count_rate in codebase #68

Open
hayesla opened this issue Jan 19, 2023 · 1 comment
Open

Distinguish between counts and count_rate in codebase #68

hayesla opened this issue Jan 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@hayesla
Copy link
Contributor

hayesla commented Jan 19, 2023

at the moment throughout the codebase the term counts is used for both counts and count rate (i.e. counts/s/keV). just for simplicity and for future development this should be clarified in codebase and docs

@samaloney
Copy link
Member

Borrowing from sunkit-spex sunpy/sunkit-spex#126 (comment)

Moreover, a naming convention is defined for different rate-like values that may exist in the instrument class, and throughout the package, as

"something Rate" refers to something s^-1
"Differential something Rate" refers to something s^-1 keV^-1
"Differential something Flux" refers to something s^-1 keV^-1 cm^-2

So initially I'd suggest to return a dictionary with the relevant name count rate differential count rate, and differential count flux or something or possibly the set some attribute which controls what is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants