Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down function inputs/outputs #25

Open
imogenagle opened this issue Jul 12, 2024 · 3 comments
Open

Break down function inputs/outputs #25

imogenagle opened this issue Jul 12, 2024 · 3 comments

Comments

@imogenagle
Copy link

Go through each function and write out descriptions of its inputs/outputs and how each function works.

@samaloney
Copy link
Member

So I think the major steps at least as far as creating the contours are:

  1. co-align (reproject with differential rotation) only the AIA data
  2. log transform
  3. make ratios
  4. clip
  5. threshold (to make binary masks)
  6. combine masks
  7. extract contours
    what do you think, something missing?

@samaloney samaloney reopened this Jul 17, 2024
@samaloney
Copy link
Member

So the google doc is great lots of detail but I guess I was more meaning to think about the things need to be done rather then the current functions etc as above what do you think of them @imogenagle?

@imogenagle
Copy link
Author

Hello! Here is an idea for the core steps that need to be done (based on both the paper and code)

  1. Re-project
  2. log conversion
  3. multi-thermal image segmentation: use Michelson contrast equation for ratios, fit a line through the minimum in intensity (hardcoded slope in log space)
  4. conjunction of 3 bitmasks
  5. extract contours
  6. reject small candidates
  7. reject candidates that are not unipolar (dependent on area)
  8. remove off-limb candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants