Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attrdict dependency as it doesn't work for Python >3.9 #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove attrdict dependency as it doesn't work for Python >3.9 #126

wants to merge 2 commits into from

Conversation

kks32
Copy link

@kks32 kks32 commented Jan 22, 2024

Description

This PR uses a local custom version of AttrDict already defined in util instead of attrdict, which is deprecated and breaks for Python >3.9

Motivation and Context

AgavePy can run on Python >3.9

How Has This Been Tested?

Types of changes

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kks32 added 2 commits January 22, 2024 09:15
@kks32
Use custom AttrDict from util
cfaae3d 
AttrDict is no longer available and this code breaks for Python > 3.9
@kks32
Remove attrdict requirements.txt
b4292f0
@jarosenb
Copy link

jarosenb commented Jan 23, 2024 •
edited
Loading

Hello Krishna,

Since Tapis V2 is on track to be completely deprecated, it's unlikely that there will be another official release on PyPI. If you need to use AgavePy with newer versions of Python, the suggested workflow is to use DesignSafe's fork of AttrDict which updates the stdlib imports for Python 3.10+ compatiblity . You can pip install it using

pip install attrdict git+https://github.com/DesignSafe-CI/AttrDict@83b779ee82d5b0e33be695d398162b8f2430ff33

Or add the following line to your pyproject.toml if using Poetry:

attrdict = { git = "https://github.com/DesignSafe-CI/AttrDict", rev = "83b779ee82d5b0e33be695d398162b8f2430ff33" }

This fork has been deployed in the DesignSafe portal for several months now with no issue, using Python 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attrdict is still used in one place.
2 participants
@kks32 @jarosenb