Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fatal issue[Bug] #14

Open
xlhd19980327 opened this issue Nov 30, 2020 · 3 comments
Open

Readme fatal issue[Bug] #14

xlhd19980327 opened this issue Nov 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@xlhd19980327
Copy link

Describe the bug
After following instruction to install LipidLynxX in the local machine(Ubuntu 18.04), I met error:

ImportError: cannot import name 'Literal' from 'typing'

To Reproduce
Steps to reproduce the behavior:
After running the main script: python LipidLynxX.py, you will get the error.

Expected Fixed Method
Change the code in this step:

Now you can create a virtual environment for LipidLynxX. For Windows users, please use the Anaconda Prompt instead of Commandline Pront or Power Shell here a virtual environment named envlynx is created. You might have to type y for enter to confirm the creation of this virtual environment.

conda create -n envlynx python=3.7

to this code
conda create -n envlynx python=3.8

Additional context
Why cause this? Because the python 3.7 do not support typing.Literal. See the link for details.

Hope you fix the Readme soon!

@xlhd19980327 xlhd19980327 added the bug Something isn't working label Nov 30, 2020
@ZhixuNi
Copy link
Collaborator

ZhixuNi commented Nov 30, 2020

Hi @xlhd19980327 !
Thanks for reporting this and test our LipidLynxX!
You are correct! LipidLynxX requires typing.Literal to run in this case and the user guide need to be updated.
I have some work around to make it compatible with 3.7, however, this require some test.

It would be nice if you can set up a pull request so I can merge your contribution in the project.
If you think its a bit complicated to create a PR for this, I will update the doc mention your contribution.

Just tell me which way you prefer and many thanks again!

@xlhd19980327
Copy link
Author

Thanks for your reply! I just changed that code(turn the environmet to python 3.8) and can deploy your server in my local machine(can only open the server port and see the interface, further test about the whole function may try later). I just found the issue and want to remind you of the bug. I'm new to github and do not have the ability to pull the changing request to your project. May you fix the bug well later!

Have a good day!:)

@xlhd19980327
Copy link
Author

I'm sorry I get something wrong. The bug step is not on readme.md file, but in LipidLynxX/doc/LipidLynxX_UserGuide.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants