Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update model files #881

Open
4 of 8 tasks
edkerk opened this issue Oct 18, 2024 · 2 comments · May be fixed by #883
Open
4 of 8 tasks

update model files #881

edkerk opened this issue Oct 18, 2024 · 2 comments · May be fixed by #883

Comments

@edkerk
Copy link
Member

edkerk commented Oct 18, 2024

Current behavior:

As long desired, RAVEN now no longer adds prefixes to metabolite, reaction, gene and compartment identifiers. It is now suitable to do some refactoring at Human-GEM of the model files and input/output functions, including some other cleanup.

Suggested changes:

  • Use RAVEN functions readYAMLmodel, writeYAMLmodel and exportForGit, instead of the Human-GEM specific importYaml, exportYaml and exportHumanGEM, to reduce the number of functions to be maintained.
  • Update README.md to reflect changes in model I/O functions, and more clearly explain the software requirements and the ability to contribute to development without RAVEN.
  • Update Human-GEM-guide to reflect changes in model I/O functions.
  • Do a full round of I/O with RAVEN 2.10.0 in develop.
  • Do a full round of I/O with RAVEN 2.10.0 in main.
  • Change Human-GEM.txt from showing metabolite identifiers to showing metabolite names + compartments. See example from yeast-GEM, where this change was introduced in 2022:
    image

Boxes above are ticked once the changes are implemented here.

To do when preparing next release

  • In main, first pass the current model version through a round of I/O with the updated functions, before merging the latest develop. This separates the changes due to different I/O routines, from all other model updates, simplifying the latter diff.
  • Update Human-GEM-guide to reflect changes in model I/O functions, after making the release.
@feiranl
Copy link
Collaborator

feiranl commented Oct 19, 2024

LGTM! Please go ahead and make changes!

@edkerk edkerk linked a pull request Oct 19, 2024 that will close this issue
3 tasks
@edkerk
Copy link
Member Author

edkerk commented Oct 19, 2024

Ticked boxes are resolved in #883, remaining will be done with new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants