Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid division by zero when totalShares is zero #2173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid division by zero when totalShares is zero #2173

wants to merge 1 commit into from

Conversation

noisekit
Copy link
Contributor

No description provided.

@noisekit noisekit requested review from dbeal-eth and Rickk137 June 14, 2024 09:49
@noisekit noisekit self-assigned this Jun 14, 2024
dbeal-eth
dbeal-eth requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems very straightforward, but we should add a test to verify outcome of condition. It's probably relatively easy to test

@noisekit
Copy link
Contributor Author

It seems very straightforward, but we should add a test to verify outcome of condition. It's probably relatively easy to test

Yeah it is not really straightforward. We do not have any tests around this stuff at all at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeal-eth dbeal-eth dbeal-eth requested changes

@Rickk137 Rickk137 Awaiting requested review from Rickk137

Requested changes must be addressed to merge this pull request.

Assignees

@noisekit noisekit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noisekit @dbeal-eth