Splitting large tests #2090
Splitting large tests #2090
Conversation
noisekit
force-pushed
the
Fix-failing-tests
branch
3 times, most recently
from
b62d973 to
0954296
Compare
noisekit
force-pushed
the
Fix-failing-tests
branch
2 times, most recently
from
feed928 to
66c4419
Compare
noisekit
force-pushed
the
Fix-failing-tests
branch
from
66c4419 to
0709de2
Compare
noisekit
force-pushed
the
Fix-failing-tests
branch
2 times, most recently
from
9110e50 to
dc75077
Compare
There was a problem hiding this comment.
Splitting it in 3 files that do the same looks wrong from code sharing... just a couple of params change on each file.
There was a problem hiding this comment.
I know but this is a simplest step to take - split and copy. Any additional abstractions can be done later if they are necessary. Personally I do believe copying is much better for tests than abstracting things. Tests are write and forget for the most parts and this is not an actively refactored piece of code that has to be always same across all tests.
|
|
||
| const MARKET_FEATURE_FLAG = ethers.utils.formatBytes32String('registerMarket'); | ||
|
|
||
| describe('IssueUSDModule', function () { |
There was a problem hiding this comment.
each shold have a different name to ease logs reading and isolation test runs
There was a problem hiding this comment.
Yeah good catch, I've missed this one here
noisekit
force-pushed
the
Fix-failing-tests
branch
from
dc75077 to
3c56813
Compare
noisekit
force-pushed
the
Fix-failing-tests
branch
from
3c56813 to
0e68fe2
Compare
No description provided.