Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the unrecognized custom error issue in tests (probably hardhat error) #273

Open
leomassazza opened this issue Oct 22, 2021 · 2 comments
Open

Fix the unrecognized custom error issue in tests (probably hardhat error) #273

leomassazza opened this issue Oct 22, 2021 · 2 comments
Assignees
@eternauta1337
Labels
blocked by 3rd party bug Something isn't working test coverage v3-core

Comments

@leomassazza
Copy link
Contributor

leomassazza commented Oct 22, 2021 •
edited
Loading

And remove the extra check in assert-revert.js when is fixed

Related to NomicFoundation/hardhat#1996
@leomassazza leomassazza added the bug Something isn't working label Oct 22, 2021
@eternauta1337 eternauta1337 changed the title Fix the unrecognized custom error issue in tests Fix the unrecognized custom error issue in tests (probably hardhat error) Oct 22, 2021
@leomassazza leomassazza mentioned this issue Oct 22, 2021
Merged
@leomassazza leomassazza self-assigned this Oct 26, 2021
@eternauta1337
Copy link
Contributor

Checked if this was fixed today, but seems like not yet. I asked to bump the priority tho.

@eternauta1337 eternauta1337 self-assigned this Dec 20, 2021
@eternauta1337 eternauta1337 mentioned this issue Dec 20, 2021
Merged
@eternauta1337
Copy link
Contributor

Had another look at this today. Still, no fixes from hh it seems.

Opened a PR to be a bit more explicit: #667

The problem still seems to be that the first time tests are run errors are not parsed, but runs fine the second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eternauta1337 eternauta1337

Labels
blocked by 3rd party bug Something isn't working test coverage v3-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eternauta1337 @leomassazza