Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Button for approving a token/submitting an order to convert is not disabled until transaction is confirmed #351

Open
drptbl opened this issue Apr 22, 2021 · 0 comments
Labels
convert Issue related to "Convert" feature enhancement New feature or request

Comments

@drptbl
Copy link
Contributor

drptbl commented Apr 22, 2021

Description:
After clicking on "Approve" button when converting a token, it stays enabled for the whole time.
Same applies to "Submit Order" button.

Prerequisites:

  • any ERC-20 asset in your wallet, for example FEI

Reproduction steps:

  1. Go to Kwenta "Convert" page (https://dev.kwenta.io/dashboard/convert)
  2. Connect your wallet
  3. Select any ERC-20 asset (for example "FEI") inside "From" drop-down
  4. Click on your asset balance to fill maximum amount to swap
  5. Click on "Approve" button (button is active all time)
  6. Click on "Submit Order" button (button is active all time)

Current behavior:

  • after clicking on "Approve" button when converting a token, it stays enabled for the whole time which could lead users to place multiple approval transactions. Same behavior for "Submit Order" button.

Expected behavior:

  • "Approve" button should be disabled until transaction is confirmed or when user changes the list to another asset.
  • "Submit Order" button should be disabled until transaction is confirmed or when user changes any amount inside input field or when users changes the list to another asset.

Screenshots:
Screenshot 2021-04-22 at 13 15 11
Screenshot 2021-04-22 at 13 17 22

Desktop (please complete the following information):

  • OS: macOS Big Sur 11.2.2
  • Browser: Chrome 89.0.4389.95
@drptbl drptbl added enhancement New feature or request convert Issue related to "Convert" feature labels Apr 22, 2021
@drptbl drptbl changed the title Button for approving a token to convert is not disabled until transaction is confirmed Button for approving a token/submitting an order to convert is not disabled until transaction is confirmed Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
convert Issue related to "Convert" feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant