Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure libraries are running full suite of SBOLTestSuite tests #11

Open
jakebeal opened this issue Nov 19, 2019 · 2 comments
Open

Make sure libraries are running full suite of SBOLTestSuite tests #11

jakebeal opened this issue Nov 19, 2019 · 2 comments

Comments

@jakebeal
Copy link
Contributor

Right now, it's not clear which of the various libraries is actually running all of the SBOLTestSuite tests. Make sure that sboljs, libSBOLj, and pySBOL are all running all of the tests. If this discovers that some are failing, log the failures as issues.

@cjmyers
Copy link
Contributor

cjmyers commented Nov 20, 2019

Shouldn't this be done by the individual repositories? The testing being currently done on travis for the SBOLTestSuite repositories is testing of the tests. Namely, it checks each file in the test suite to make sure that it indeed functions as advertised. Namely, files in SBOL2 validate including best practices, SBOL2_bp validate excluding best practices, SBOL2_ic validate excluding best practices and completeness, and SBOL2_nc validate excluding best practices, completeness, and compliant URIs. The files in the GenBank and SBOL1 directories must successfully convert to valid SBOL2 documents. The files in the Invalid directory must be invalid precisely for the rule specified by their filename.

Are you looking for something else to be performed here?

@jakebeal
Copy link
Contributor Author

This is, indeed, in reference to the individual libraries; I put it here as a cross-library issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants