Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceRestriction.Overlaps definition #503

Open
goksel opened this issue Nov 18, 2022 · 1 comment
Open

SequenceRestriction.Overlaps definition #503

goksel opened this issue Nov 18, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@goksel
Copy link
Contributor

goksel commented Nov 18, 2022

The overlaps definition is described by using the start and end of the subject. Would it not also be valid to describe the same relationship using the object's start and end positions?

For example, if the subject has a range of 9-12 and the object has a range of 7-10, then according to the current definition, the subject does not overlap with the object.

"The start of the location for subject is before the start of the location for object and the end of the location for subject is before the end of the location for object."

@goksel goksel added this to the Version 3.2.0 milestone Nov 18, 2022
@jakebeal
Copy link
Contributor

In the interval algebra which these relations is drawn from, overlaps is NOT symmetric: A overlaps B implies that B does not overlap A.

This does, in fact, mean that "overlap" has a stronger set of conditions in the context of intervals than it does topologically (where it is symmetric), but both of those meanings are long established mathematical vocabulary, and I don't think that we should modify them. There is also clear value in being able to distinguish between a 5' overlap and a 3' overlap (which this allows).

There is already a note about this in Table 10, but please feel free to set up a PR that proposes an enhanced explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants