Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider new name for SbolService #39

Open
mgaldzic opened this issue May 31, 2011 · 0 comments
Open

consider new name for SbolService #39

mgaldzic opened this issue May 31, 2011 · 0 comments
Milestone

Comments

@mgaldzic
Copy link
Member

service as is not an intuitive name

SbolService contains many methods for creating and adding new SBOL objects to the Entity Manager
What is the appropriate name for this class.
or What better design should we consider for the library so that it is more convenient for users of the library?
ie For me the decision lies in what will be a little easier for a new user to expect from a name of a class.

A conversation about this began early on:

Tim said: SomethingService implies (at least to me) some
asynchronous operation with a third party server (usually over the
internet). Servers provide Service. Perhaps that's just me.

Mike said: I adopted the term from a JPA example, http://www.java2s.com/Code/Java/JPA/UpdateAnEntity.htm
see ProfessorService
In their case they pass the EntityManager to the Service.
The "service" term comes from offering the transaction methods it performs in managing the store or other persistence object.
So the other options would be SbolManager, SbolEntityManager, or LibraryEntityManager.

The Sbol prefix is generic, however our outer container is a Library. There can be no Thing outside of a Library.
So LibraryService may work, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant