Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with retried messages & delay #25

Open
nikophil opened this issue Mar 13, 2020 · 4 comments · May be fixed by #27 or #43
Open

Problem with retried messages & delay #25

nikophil opened this issue Mar 13, 2020 · 4 comments · May be fixed by #27 or #43
Milestone

Comments

@nikophil
Copy link
Collaborator

nikophil commented Mar 13, 2020

I don't known if the delay of the retried messages should be count or not in the waiting_time

i got the feeling it corrupts the stats: if a queues works "normally" it should have average waiting times between 0 and 1s

but with the delay, it is abnormally high

@nikophil nikophil added this to the first release milestone Mar 13, 2020
@nikophil
Copy link
Collaborator Author

WDYT @weaverryan ?

@weaverryan
Copy link
Contributor

Ooooooh. That's a good catch. Hmm. I guess it would be better if the waiting time did not take this into consideration - e.g. if there was a delay on a message of 5 seconds, and it took 5.5 seconds to handle it, then .5 seconds is the "waiting time". Is that feasible to do?

@nikophil
Copy link
Collaborator Author

it is is totally feasible: i can add an $offset parameter to StoredMessage::updateWaitingTime() which will be the value of last DelayStamp if any exist

@nikophil
Copy link
Collaborator Author

(i'm gonna do that in the current PR)

@nikophil nikophil linked a pull request Mar 22, 2020 that will close this issue
@bendavies bendavies linked a pull request Sep 29, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants