From 6ff509f833ecca19fc14eebd4c62a9ccf7bc2b26 Mon Sep 17 00:00:00 2001 From: David Cooley Date: Tue, 10 Apr 2018 07:53:52 +1000 Subject: [PATCH] fixed cran issues --- DESCRIPTION | 6 ++++-- cran-comments.md | 2 ++ man/rapidjsonr-package.Rd | 6 ++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 59c96c6..3441e07 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -4,9 +4,11 @@ Title: 'Rapidjson' C++ Header Files Version: 1.0.0 Date: 2018-04-09 Authors@R: c( - person("David", "Cooley", ,"dcooley@symbolix.com.au", role = c("aut", "cre")) + person("David", "Cooley", ,"dcooley@symbolix.com.au", role = c("aut", "cre")), + person("Milo", "Yip", , role = "ctb", comment = "Author of c++ rapidjson library, provided through THL A29 Limited, a Tencent company"), + person("Alexander", "Chemeris", role = "ctb", comment = "Author of c++ msinttypes library") ) -Description: Proivdes JSON parsing capability through the 'Rapidjson' 'C++' header-only library. +Description: Provides JSON parsing capability through the 'Rapidjson' 'C++' header-only library. License: MIT + file LICENSE Encoding: UTF-8 LazyData: true diff --git a/cran-comments.md b/cran-comments.md index 5b3bee5..0f7b756 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -11,6 +11,8 @@ ## Response to CRAN Submission change requests +* add c++ library authors to DESCRIPTION +* fixed spelling mistake in DESCRIPTION * changed the description to better describe the package * single-quotes added around software names * added MIT template license diff --git a/man/rapidjsonr-package.Rd b/man/rapidjsonr-package.Rd index efa73b6..ce33d44 100644 --- a/man/rapidjsonr-package.Rd +++ b/man/rapidjsonr-package.Rd @@ -19,4 +19,10 @@ include \author{ \strong{Maintainer}: David Cooley \email{dcooley@symbolix.com.au} +Other contributors: +\itemize{ + \item Milo Yip (Author of c++ rapidjson library, provided through THL A29 Limited, a Tencent company) [contributor] + \item Alexander Chemeris (Author of c++ msinttypes library) [contributor] +} + }