Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolodate with RcppSimdJson #71

Open
dcooley opened this issue Jun 18, 2020 · 5 comments
Open

consolodate with RcppSimdJson #71

dcooley opened this issue Jun 18, 2020 · 5 comments

Comments

@dcooley
Copy link
Collaborator

dcooley commented Jun 18, 2020

Given RcppSimdJson:::..deserialize_json() can replicate the behaviour of jsonify::from_json(), should I include RcppSimdJson as a LinkingTo, and use it if the end-user's hardware is up to it?


A wider question for @eddelbuettel & @knapply :

Do you think it's worth consolodating these libraries into one R package, which will automatically call either the simdjson or rapidjson .h code depending on the user's hardware?

Then there will only be one package which does both the from_json() and to_json()

@eddelbuettel
Copy link

Good questions. I don't know. Good thing is I think we're not in a rush.

@knapply
Copy link
Contributor

knapply commented Jun 18, 2020

Can LinkingTos be optional like Suggests?

As things currently stand, that would eliminate jsonify as an option for Windows and those lacking C++17 compilers.

@eddelbuettel
Copy link

Can LinkingTos be optional like Suggests?

No. Only Suggests: has optionality :-/

@JosiahParry
Copy link

It would be nice. I'm presently using both in a package I'm developing :)

@eddelbuettel
Copy link

I actually implemented a 'conditional' LinkingTo: once in a package in configure logic. If the (otherwise) Suggests:-only package is present, add a -I.... to the preprocessor/compiler flags. Easy enough and reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants