Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented queries #12

Open
ghost opened this issue Oct 3, 2018 · 2 comments
Open

Implemented queries #12

ghost opened this issue Oct 3, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 3, 2018

Hi,

I only see the rdf data cube constraints coming from the spec implemented.
I expected to find some additional queries to test if the data comply to the additional constraints the swirrl processing pipelines impose such as the required use of qb:measureType even in the context of having just one measurement.
Have I overlooked something?

@lkitching
Copy link
Collaborator

@paulzh - Those validation queries are defined in the graphql-qb repository, currently on the issue_127 branch in the validation folder. See the Data validation section of the README in that branch.

@Robsteranium
Copy link
Contributor

I presume you're talking about table2qb input validation? Indeed we should add that - there's an issue for the codelist-pipeline but the others pipelines deserve validation too. I suspect we'd implement this by inspects the tabular inputs - e.g. comparing the column headings/ contents with the config - rather than the rdf outputs not least because you mightn't be able to even generate an output given invalid input.

Please note that the measure type is only required because we've not got around to implementing the multi-measure approach yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants