-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facebook Login #19
Comments
That seems an old post i guess |
Should still work how it is supposed to, I'll try to implement this later today if that is cool? |
[WIP] fix for SurfEdge#19
@Felli Yes sure. That would be great 👍 |
Since our App is not native, Facebook SDK won't help. Can you please try this |
@punit2502 that is simple enough, I'll also do some test runs of this. 👍 |
How is the progress on this @Felli any luck? 😃 |
Sadly no, I've not had the time as of yet to complete this, although I'll try to get this done by next weekend if possible. |
@chamathpali @Felli I found something. That may give some ideas. (Also white page URL is: "yourwebsite.tld/auth/facebook?code=fbauthCode") For now, I just added:
And, here's how it looks in app. (When you press the Facebook login button.) |
@Felli disabling popups would just make it do nothing? Here's how Facebook works. You press the "login with fb" button. A new window opens. You enter your information. Allow using that app. The final link in that popup window is a flarum link. Which is example.com/auth/facebook?... at that window auth completes and popup closes. The window below now saved this via cookie manager and knows that you're logged in. What we need is detecting a popup, and adding to onPageFinish, something like url.startsWith("https://flarum.org/auth/facebook?") { I've tried this but there's a small problem. You can login Facebook. After window, you do get redirected to your flarum site, BUT, you're not signed in. There's a way to sign in as I mentioned above but it's broken. Remember me adding swipe down to reload? Now step by step to login:
What I'm thinking is: I'll try to solve it now. If I can I will release a version with swipe down refresh + working Facebook login. (working anything popup login) |
I myself am testing out this method here at the moment, and have a apk file created and waiting for testing, the only issue I'm having is creating a key hash for Facebook. |
Facebook login is a crucial part we need to solve in the mobile apps. 😞 lets try to get some work around soon |
I believe something like this could help fix this issue. 👍
The text was updated successfully, but these errors were encountered: