Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring numbers in HI removal? #9052

Open
Boulder08 opened this issue Dec 2, 2024 · 3 comments · May be fixed by #9058
Open

Ignoring numbers in HI removal? #9052

Boulder08 opened this issue Dec 2, 2024 · 3 comments · May be fixed by #9058

Comments

@Boulder08
Copy link

Is it possible to make SE ignore two corner cases like the ones highlighted in this example?

image
@ivandrofly
Copy link
Member

This is not related with remove HI, the time is not well formatted!
There is white space between "11" and ":".

Added ignore logic will allow more buggy text.

Maybe a rule need to be added where (maybe in FCE) to handle this case.

@Boulder08
Copy link
Author

I was thinking along the lines of ignoring anything after the first ":" (line 214) and also ignoring cases where there are only numbers before the character like on line 218.

ivandrofly added a commit to ivandrofly/subtitleedit that referenced this issue Dec 3, 2024
@ivandrofly
Improve regex for detecting numeric separators
34129d1 
Renamed and enhanced the regex to better match numeric values separated by punctuation with or without spaces. This change improves the text processing accuracy by adjusting how separators are recognized between numbers. The updated regex should cover more use cases in text parsing scenarios.

Fixes SubtitleEdit#9052

Signed-off-by: Ivandro Jao <[email protected]>
@ivandrofly ivandrofly linked a pull request Dec 3, 2024 that will close this issue
Open
@ivandrofly
Copy link
Member

Just opened a pull-request with the fixes. If merge happen you will still need to run the Fix Common Errors (FCE)
with option Remove unneeded spaces ticked to handle invalid time and then run Remove text from hearing impaired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve regex for detecting numeric separators ivandrofly/subtitleedit
2 participants
@ivandrofly @Boulder08