-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRC Lyrics ms (.lrc) rounding issue, discarded empty lines and improper use of the ti: tag #9048
Comments
I've tried to fix the timestamps in the LRC milliseconds format here: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip In Options - Settings, you can set the max duration to something higher, to avoid cutting lines at 8 seconds: |
I could make a new format |
That should eliminate the
|
Opening this .lrc file in SubtitleEdit and saving it with
LRC Lyrics ms (.lrc)
as the format without performing any changeyields these rounded timestamps:
SubtitleEdit seems to also assume the max line duration to be 8s, (which for this song for example is too short). This cuts lines short and inserts empty lines within the lyrics.
Saving the initial file (without changing anything) as
LRC Lyrics, no end time (.lrc)
on the other hand simply removes all empty lines:One might argue that the empty line timestamps in the initial file are invalid (2 lines start with the same timestamp), but they're from Deezer and fairly common. However SubtitleEdit also ignores valid empty lines like this one from another song that contains a passage without singing:
At least the second case should retain the empty lines.
On another note:
According to the wikipedia page,
ti
is supposed to contain the song title, not the filename without extension, so setting it to this automatically is problematic as well.After fixing the timings in SubtitleEdit, adding back the passages without singing and saving the result as
LRC Lyrics, no end time (.lrc)
, it correctly saves these empty lines. But when reopening the file, they are gone again.Ideally I'd like SubtitleEdit to open the .lrc files while retaining (valid) empty lines and save the result after syncing without end timestamps but with ms precision (and without setting the filename as ti).
The text was updated successfully, but these errors were encountered: