-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve linux support (new launcher) #1848
base: master
Are you sure you want to change the base?
Conversation
cfb2938
to
dc11b8b
Compare
49cf07d
to
bbfcd47
Compare
With that, we present to you the Cross-Platform launcher. Have fun reviewing this 🌚 |
I have just tested this build on Linux, it does not support server save files from earlier versions or launch on Linux. While the new launch looks and feels great it fails to address the original issue of Linux support. The current version of the launcher is more functional on Linux, however, it fails to detect a running Steam instance so it doesn't launch the game. If we just fixed the code for detecting Steam it should let us avoid rewriting the entire launcher. |
Nitrox v1.8.0.0 is not meant to support older save files since there were major changes made to the build system. |
Still looks weird with the exiting animation (as if the brush transition takes place after the opacity transition)... not sure why
FINALLY... it's 3:30am and I got this figured out. I have no idea how I ended up with this black magic that you see before you, but it works pretty well. Please let me know if I've committed any unforgivable sins in these changes :) On a more serious note, I think the scroll animation looks way better than it did before, but it still feels slightly jittery. And I don't like how I had to rely on a "LastOffset" property for this to work properly, but it's the best that I could come up with seeing that "ScrollViewer.Offset" is already changed to the target scroll value when this code is being run.
It now stays in sync with scroll offset changes outside of mouse wheel. The animation target is now updated instead of recreating animation causing slight jitter.
Reusing views will allow scrollbar position to be remembered.
Added link to GitHub showing contributions made in the last year.
FileSystemWatcher can cause this race-condition with a manual insert. So the manual insert was removed.
Co-authored-by: dartasen <[email protected]>
XAML Styler plugin auto formatted on save but there's a bug here where it formats selector syntax too...
dotnet build
on dotnet SDK 8+NitroxLauncher
to play Subnautica with Nitrox.NitroxLauncher
)This PR includes solution-wide changes to multi-target for .net 9 (server, launcher) and .net 4.7.2 (game client), allowing benefits of modern .net where possible.
Closes #988
Resources to assist with implementation