Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert link accent styling in file table #1332

Open
pointydev opened this issue Nov 2, 2021 · 0 comments
Open

Revert link accent styling in file table #1332

pointydev opened this issue Nov 2, 2021 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@pointydev
Copy link

pointydev commented Nov 2, 2021

Describe the change you'd like
I think primary and secondary file links should be a different shade/the default colour, as using the accent colour can look extremely overwhelming at a cursory glance.

Additional context
See this comment thread on the offending commit: 2274055#r58142290. @srichter also kindly made a snippet to revert this, however I don't think a theme with this level of customisation should have to resort to snippets like this.

@Geeyun-JY3 also highlighted the following point, which provides a rationale behind reverting it other than "it looks better":

And if commit message contains # and issue or pull request number, it would make users overlook the short link.

Thanks,
Elliott

@the-j0k3r the-j0k3r added bug 🐛 Something isn't working and removed feature 😍 labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants