Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong types for ManifestConfig #295

Open
hexdecimal16 opened this issue Aug 21, 2024 · 1 comment
Open

Wrong types for ManifestConfig #295

hexdecimal16 opened this issue Aug 21, 2024 · 1 comment

Comments

@hexdecimal16
Copy link

hexdecimal16 commented Aug 21, 2024

This is the current ManifestConfig:

/**
 * Addon setting.
 */
export interface ManifestConfig {
    /**
     * A key that will identify the user chosen value.
     */
    key: string;

    /**
     * The type of data that the setting stores.
     */
    type: ManifestConfigType;

    /**
     * The default value. For `type: "boolean"` this can be set to "checked" to default to enabled.
     */
    default?: string;

    /**
     * The title of the setting.
     */
    title?: string;

    /**
     * List of (string) choices for `type: "select"`
     */
    options?: string;

    /**
     * If the value is required or not. Only applies to the following types: "string", "number". (default is `false`)
     */
    required?: string;
}

This doesn't respect the documentation here: https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/manifest.md#user-data

@jaruba
Copy link
Member

jaruba commented Aug 21, 2024

required is most definitely not a string, it's a boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants