Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename is not on the defineSubtitlesHandler extra property #248

Open
daniel-lxs opened this issue Nov 28, 2023 · 4 comments
Open

Filename is not on the defineSubtitlesHandler extra property #248

daniel-lxs opened this issue Nov 28, 2023 · 4 comments

Comments

@daniel-lxs
Copy link

According to this: https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/requests/defineSubtitlesHandler.md#extra-parameters

The argument "extra" passed to defineSubtitlesHandler should get a "filename" property however I'm getting undefined when trying to access it:
image

Is there any way around this? Without this property I can't search subtitles based on keywords in the filename thus having to try each subtitle one by one instead of just getting the one for that specific file.

Thank you.

@jaruba
Copy link
Member

jaruba commented Nov 28, 2023

On what platform are you testing? We are still working on getting the same behavior across all apps for subtitle addons, we are also including new behavior hints for streams related to this: #249

@daniel-lxs
Copy link
Author

Thank you for answering so fast. I'm on Linux and tried the desktop and web version, neither send the filename to the plugin's endpoint.

@dexter21767-dev
Copy link
Member

afaik this is only returned for torrent streams and not used for HTTP streams. are u testing using an HTTP stream (debrid for example)?

@daniel-lxs
Copy link
Author

Yes I am using a debrid service, is it not possible to get the filename from a HTTP stream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants