Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func_illusionary should not contain solid keyvalue #78

Open
VortexParadox opened this issue Aug 6, 2021 · 6 comments
Open

func_illusionary should not contain solid keyvalue #78

VortexParadox opened this issue Aug 6, 2021 · 6 comments

Comments

@VortexParadox
Copy link

func_illusionary should not contain the solid keyvalue as this entity can not be solid in any way

@braem
Copy link
Member

braem commented Aug 6, 2021

What keyvalues should it have? It inherits everything from its bases so it's quite ugly to remove.
Or maybe add support to exclude a value from a base? Might encourage terrible inheritance though, and also would need changing in srctools I imagine.

@VortexParadox
Copy link
Author

I'm just noticing func_wall and func_brush seem to outright ignore this key. What does this change and, in the case of func_brush, how is it different from Solid Type (solidbsp). Is this implemented?

@VortexParadox
Copy link
Author

VortexParadox commented Aug 6, 2021

To me it looks like solid is a combination of solidity and solidbsp. But I don't know if it's currently conflicting and not working or if solid doesn't change anything

@hexaflexahexagon
Copy link
Member

func_illusionary has these keyvalues in the TF2 fgd:
image
image

I'm just noticing func_wall and func_brush seem to outright ignore this key. What does this change and, in the case of func_brush, how is it different from Solid Type (solidbsp). Is this implemented?

Setting the solid type to BSP will mean that the bug where func_brush compiled to be 0.5 units smaller on every face than it was in hammer no longer happens, though I believe it also means that any func_brush that uses BSP collision cannot move. See momentum-mod/game#719

@tmob03
Copy link
Member

tmob03 commented Jun 15, 2022

Could make it read-only like func_areaportal and func_areaportalwindow's "Portal Version" keyvalue. Wouldn't stop people from changing it by turning off smartedit but would stop most. Would this be acceptable?

@hexaflexahexagon
Copy link
Member

I'd probably prefer if it were just not visible completely as it still causes confusion and clutter. If that's determined to not be possible or feasible read only would work tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants