From dc113d34a1807591301c32cc1197690e8572050d Mon Sep 17 00:00:00 2001 From: Unreal-Dan <72595612+Unreal-Dan@users.noreply.github.com> Date: Fri, 3 Nov 2023 04:46:04 -0700 Subject: [PATCH] de-virtualized the Mode class (#133) These apis were made virtual out of hopefulness but derivations of Mode were never realized. --- VortexEngine/src/Modes/Mode.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/VortexEngine/src/Modes/Mode.h b/VortexEngine/src/Modes/Mode.h index 1542b6d9f1..9e75e2b9bb 100644 --- a/VortexEngine/src/Modes/Mode.h +++ b/VortexEngine/src/Modes/Mode.h @@ -46,7 +46,7 @@ class Mode Mode(PatternID id, const PatternArgs &args, const Colorset &set); Mode(PatternID id, const PatternArgs *args, const Colorset *set); Mode(const Mode *other); - virtual ~Mode(); + ~Mode(); // copy and assignment operators Mode(const Mode &other); @@ -57,19 +57,19 @@ class Mode bool operator!=(const Mode &other) const; // initialize the mode to initial state - virtual void init(); + void init(); // Play the mode - virtual void play(); + void play(); // save/load from a buffer for individual mode sharing - virtual bool saveToBuffer(ByteStream &saveBuffer, uint8_t numLeds = 0) const; - virtual bool loadFromBuffer(ByteStream &saveBuffer); + bool saveToBuffer(ByteStream &saveBuffer, uint8_t numLeds = 0) const; + bool loadFromBuffer(ByteStream &saveBuffer); // save the mode to serial - virtual void serialize(ByteStream &buffer, uint8_t numLeds = 0) const; + void serialize(ByteStream &buffer, uint8_t numLeds = 0) const; // load the mode from serial (optional led count) - virtual bool unserialize(ByteStream &buffer); + bool unserialize(ByteStream &buffer); // mode comparison bool equals(const Mode *other) const;