From 6cb2d00d8d04290456e062fcedc071549a97ea20 Mon Sep 17 00:00:00 2001
From: Steven de Oliveira <de.oliveira.steven@gmail.com>
Date: Wed, 22 Nov 2023 16:45:09 +0100
Subject: [PATCH] Poetry

---
 src/lib/reasoners/satml_frontend.ml | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/lib/reasoners/satml_frontend.ml b/src/lib/reasoners/satml_frontend.ml
index c312d3a99..585d7cf50 100644
--- a/src/lib/reasoners/satml_frontend.ml
+++ b/src/lib/reasoners/satml_frontend.ml
@@ -806,7 +806,7 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
             let ff_abstr,new_proxies,proxies_mp, new_vars =
               FF.cnf_abstr env.ff_hcons_env ff env.proxies acc.new_vars
             in
-            let () = env.proxies <- proxies_mp in
+            env.proxies <- proxies_mp;
             let nunit =
               List.fold_left FF.expand_proxy_defn acc.nunit new_proxies
             in
@@ -1078,10 +1078,11 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
       else Expr.Reals.(>)
     end
 
-  let analyze_unknown_for_objectives env unknown_exn unsat_rec_prem : unit =
+  (* This function is called after receiving an `I_dont_know` exception from
+     unsat_rec. It may re-raise this exception. *)
+  let analyze_unknown_for_objectives env unsat_rec_prem : unit =
     let obj = Th.get_objectives (SAT.current_tbox env.satml) in
-    if Util.MI.is_empty obj then raise unknown_exn;
-    env.objectives <- Some obj;
+    if Util.MI.is_empty obj then raise I_dont_know;
     let acc =
       try
         Util.MI.fold
@@ -1103,9 +1104,10 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
         (* The answer for the first objective is infinity. We stop here as
            we cannot go beyond infinity and the next objectives with lower
            priority cannot be optimized in presence of infinity values. *)
-        raise unknown_exn;
+        raise I_dont_know;
 
       | (e, tv, is_max, is_le) :: l ->
+        env.objectives <- Some obj;
         let neg =
           List.fold_left
             (fun acc (e, tv, is_max, is_le) ->
@@ -1138,7 +1140,6 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
         unsat_rec_prem env ~first_call:false
     end
 
-
   let rec unsat_rec env ~first_call:_ : unit =
     try SAT.solve env.satml; assert false
     with
@@ -1205,9 +1206,9 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
     try
       unsat_rec env ~first_call
     with
-    | I_dont_know as e ->
+    | I_dont_know ->
       begin
-        try analyze_unknown_for_objectives env e unsat_rec_prem
+        try analyze_unknown_for_objectives env unsat_rec_prem
         with
         | IUnsat (env, _) ->
           assert (env.objectives != None);