Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Multi-Platform Docker Images and Build Pipelines to SGDK #290

Closed
justgook opened this issue Aug 11, 2023 · 0 comments · Fixed by #316 · May be fixed by #292
Closed

Adding Multi-Platform Docker Images and Build Pipelines to SGDK #290

justgook opened this issue Aug 11, 2023 · 0 comments · Fixed by #316 · May be fixed by #292

Comments

@justgook
Copy link
Contributor

justgook commented Aug 11, 2023 •
edited
Loading

Greetings SGDK community,

I hope this message finds you well. I'm excited to present a proposal aimed at elevating the SGDK project by introducing multi-platform Docker images and streamlining the build process using GitHub Actions. As part of this initiative, I'm also planning to remove the reliance on Wine within the Docker setup and create a unified Dockerfile that can be used across various architectures, including x86 and aarch64.

Proposal:

  1. Multi-Platform Docker Images: My goal is to design Dockerfiles and build scripts that produce Docker images capable of supporting diverse platforms, eliminating concerns about compiler compatibility. This enhancement will allow developers to effortlessly utilize SGDK on different systems.

  2. Unified Build Pipelines: In conjunction with the Docker improvements, I plan to establish GitHub Actions build pipelines to automate the process of rebuilding artifacts post-commit. This approach ensures that SGDK's libraries, samples, and core components remain up-to-date and aligned with any modifications.

  3. Removing Wine Dependency: As part of this effort, I intend to refactor the Docker setup to remove the dependency on Wine. By doing so, we can create a more streamlined and consistent build environment.

Contributions I Can Provide:

I'm fully prepared to take the lead on implementing these enhancements. Having already successfully compiled GCC for aarch64 on my MacBook, I bring experience in Docker and configuring CI/CD pipelines to the table. I'm eager to contribute towards the objective of making SGDK universally accessible and user-friendly.

Welcoming Your Insights:

I hold your expertise in high regard and invite your invaluable feedback, guidance, and insights on this proposal. By collaborating, we have the opportunity to elevate SGDK's capabilities and extend its accessibility to a broader spectrum of developers.

Thank you for considering this proposal. I'm looking forward to actively contributing to SGDK and engaging with the community.

Best regards,
Romans
This was referenced Aug 13, 2023
Closed
Open
joeyparrish pushed a commit to joeyparrish/SGDK that referenced this issue Mar 10, 2024
@justgook @joeyparrish
Add multi-platform docker image
1b61f73 
Rebased, cleaned-up version of PR Stephane-D#292

Compared with Stephane-D#292, this:
 - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31)
 - has no changes to newline styless, so the diff is easier to read
 - adds instructions to readme.md on building deps/gcc.Dockerfile
 - fix case on gcc docker image (must be lowercase apparently)
 - fixes typos

Resolves Stephane-D#290
@joeyparrish joeyparrish mentioned this issue Mar 10, 2024
Merged
joeyparrish pushed a commit to joeyparrish/SGDK that referenced this issue Mar 11, 2024
@justgook @joeyparrish
Add native docker images w/ build workflow
d2c638f 
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that
do not rely on Wine, with a GitHub Actions workflow to build and push
Docker images to ghcr.io.

Compared with Stephane-D#292, this:
 - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31)
 - has no changes to newline styless, so the diff is easier to read
 - adds instructions to readme.md on building deps/gcc.Dockerfile
 - fix case on gcc docker image (must be lowercase apparently)
 - fixes typos
 - streamlines and simplifies the GitHub Actions workflow
 - disables arm64 image builds because they keep hanging in the GitHub
   Actions environment

Resolves Stephane-D#290
joeyparrish pushed a commit to joeyparrish/SGDK that referenced this issue Mar 11, 2024
@justgook @joeyparrish
Add native docker images w/ build workflow
328de48 
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that
do not rely on Wine, with a GitHub Actions workflow to build and push
Docker images to ghcr.io.

Compared with Stephane-D#292, this:
 - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31)
 - has no changes to newline styless, so the diff is easier to read
 - adds instructions to readme.md on building deps/gcc.Dockerfile
 - fix case on gcc docker image (must be lowercase apparently)
 - fixes typos
 - streamlines and simplifies the GitHub Actions workflow
 - disables arm64 image builds because they keep hanging in the GitHub
   Actions environment

Resolves Stephane-D#290
Resolves Stephane-D#304
joeyparrish pushed a commit to joeyparrish/SGDK that referenced this issue Mar 11, 2024
@justgook @joeyparrish
Add native docker images w/ build workflow
ec7dd55 
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that
do not rely on Wine, with a GitHub Actions workflow to build and push
Docker images to ghcr.io.

Compared with Stephane-D#292, this:
 - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31)
 - has no changes to newline styless, so the diff is easier to read
 - adds instructions to readme.md on building deps/gcc.Dockerfile
 - fix case on gcc docker image (must be lowercase apparently)
 - fixes typos
 - streamlines and simplifies the GitHub Actions workflow
 - disables arm64 image builds because they keep hanging in the GitHub
   Actions environment

Resolves Stephane-D#290
Resolves Stephane-D#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@justgook