Immediate-store all of view dialog #3987
Draft
+786
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fix smooth fading of rectangular FOV box
- Final NomenclatureMgr fix - Move planet visual magnitude selection logic to SolarSystem property (This also fixes a missing RemoteSync property not syncing) - Update URL for JUPOS
- also move selection of single constellations to starlore and add isolated setting as well. Properties/config keys should be named more fittingly.
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
|
Hello @gzotti! Thank you for the suggested improvement. |
alex-w
reviewed
Nov 25, 2024
| // These are to find out the best sky parameters. Program feature for debugging/expert mode. | ||
| // These will be connected from AtmosphereDialog and forward the settings to SkyLight class. | ||
|
|
||
| void StelSkyDrawer::setFlagDrawSunAfterAtmosphere(bool val){ |
alex-w
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues a series of changes which aims at optionally avoiding the requirement to press "save settings".
All features in the view settings dialog should be immediate-store so far.
The Configure dialog is still to be done.
The Language settings are probably the only settings that crucially needs to be protected by an extra (upcoming) confirmation so they are not messed up on a panic exit. All other settings are as easy to reset as they were set.
In the end of this branch, the "save settings" button will be toggled off when the corresponding "immediate storage" option in the config dialog has been activated, and a "save languages" will appear.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: