Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializer with .NET 6 and Eureka has some unexpected behaviour when run locally - also some suggestions #81

Open
Layla-P opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Layla-P
Copy link

Layla-P commented May 24, 2022

Please be sure to check the existing issues (both open and closed!).

Issue description

The way the sample app is created now is somewhat confusing.
launchsettings.json only has http://localhost:5000 - I would expect it to also contain https://localhost:5001
Program is using .UseCloudHosting(<PORTNUMBER>), I would at least expect this to have .UseCloudHosting(<PORTNUMBER>, <SECUREPORTNUMBER>)
When running locally, without "Urls":"https://localhost:5001" in the appsettings.json the app will not register localhost - suggestion - add this by default to the appsettings.Development.json file.

I would also suggest adding code comments to draw the user's attention to the various moving parts to greater assist with their learning and comprehension.

I would also consider using the minimal hosting pattern for .NET 6 as this is more in line with current MS dotnet new templates.

@ccheetham and I discussed the above on a call

@Layla-P Layla-P added the bug Something isn't working label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant