Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

Manually added non-Steam games covers don't update - wrong ID on filenames #130

Open
SantaHey opened this issue Mar 30, 2021 · 6 comments
Open

Comments

@SantaHey
Copy link
Contributor

SantaHey commented Mar 30, 2021

I have non-steam games added manually and covers selected in SteamGridDB aren't updated in Steam.
SteamGridDB seems to add images but with wrong filenames.

Covers of games from others launchers are imported and work well.

Filename in config\grid of image added manually
image
Filenames in config\grid of image added with SteamGridDB
image

Comparaison of files added in config\grid :
image

log.log

EDIT 05.04.2021
After researches I found where is the problem. SteamGridDB loads and writes manually added non-steam game with the wrong filenames. I describe the problem and create a pull request for fix it here #136.

I build my own version with the fix to help somebody who needs it before my code will be reviewed.
For information, the release also contains fixes for the next issues #135 and #134

Link of my self-built release : https://drive.google.com/drive/folders/1A5tdYZ0iNK4tHMuAfCRnzaelsXZ65wRC

@lucasfads
Copy link

Same issue.
If I decide to add the artwork manualy it's then added with a different id/filename than the one SteamGridDB is giving.

@SantaHey SantaHey changed the title Manually added non-Steam games covers don't update Manually added non-Steam games covers don't update - wrong ID on filenames Apr 5, 2021
SantaHey added a commit to SantaHey/steamgriddb-manager that referenced this issue Apr 5, 2021
As I said here : SteamGridDB#130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB).

After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here,

It results that SteamGridDB update images with the wrong ID's

My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.
@SantaHey
Copy link
Contributor Author

SantaHey commented Apr 5, 2021

Same issue.
If I decide to add the artwork manualy it's then added with a different id/filename than the one SteamGridDB is giving.

@lucasfads I found a way to fix the problem and describe it in the original post.
I publish a built version with my fix if you want to install it.

@lucasfads
Copy link

Same issue.
If I decide to add the artwork manualy it's then added with a different id/filename than the one SteamGridDB is giving.

@lucasfads I found a way to fix the problem and describe it in the original post.
I publish a built version with my fix if you want to install it.

AMAZING! It seems to be working just fine.
Thank you and congratulations for the great work @SantaHey!

kongomongo pushed a commit to kongomongo/steamgriddb-manager that referenced this issue May 1, 2021
As I said here : SteamGridDB#130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB).

After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here,

It results that SteamGridDB update images with the wrong ID's

My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.
@CorporalPig22
Copy link

CorporalPig22 commented May 8, 2021

The only real issue I found with your self-built version is when I tried to add grid images for any Pixar game (except Rise of the Underminer, Mater-National Championship, Toy Story 1 and 2, A Bug's Life, Monsters Inc., and Buzz Lightyear of Star Command), it gave me images for Brave instead of what I actually wanted (Cars, The Incredibles, etc.).

@SantaHey
Copy link
Contributor Author

SantaHey commented May 9, 2021

@CorporalPig22 It didn't gave you this in the downloadable version ?
Because I didn't touch the search function.

@Leafar-21
Copy link

@SantaHey
(I'm using google translator, I'm from Brazil) Thanks man, your version is working perfectly, it also fixed the problem of not being able to change the logos, again thank you very much

doZennn pushed a commit that referenced this issue Aug 8, 2021
As I said here : #130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB).

After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here,

It results that SteamGridDB update images with the wrong ID's

My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants