Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical price for TBoI: Repentance is always given in USD #183

Open
deviant opened this issue Jun 28, 2024 · 1 comment
Open

Historical price for TBoI: Repentance is always given in USD #183

deviant opened this issue Jun 28, 2024 · 1 comment
Labels

Comments

@deviant
Copy link

deviant commented Jun 28, 2024

Describe the bug

This page lacks a priceCurrency meta tag, and thus falls back to USD. I'm not sure where else one would get this information from. The corresponding page for the base game has the tag as expected, so one could work around this by also requesting this.

There's also the numerical currency code of the user's cart, but I don't know how to map this into the textual representation, and maybe this has some other downsides I'm not aware of. This can be found as follows: JSON.parse(document.querySelector('#application_config').dataset.store_user_config).accountcart.cart.subtotal.currency_code.

I don't know why this page is special, it doesn't seem to be the fact that it's a DLC (other DLCs don't have this problem— even DLCs for the same game). Is it because the game can only be bought as part of a bundle? There's no individual purchase option here (perhaps since I already own all other items in the bundle?). Here's a screenshot:

image

Browser name and version

Firefox 127.0.2 (presumably irrelevant for this issue)

@deviant deviant added the bug label Jun 28, 2024
@xPaw
Copy link
Member

xPaw commented Jun 28, 2024

The meta info is probably missing because of the bundles only yeah.

The currency id can be mapped to string with GetCurrencyCode( 3 ); but this function doesn't exist on store pages, and I'm not very keen to put the mapping into the extension code. Plus, the cart json is null if you're not logged in (and won't take into account ?cc param).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants