Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-importing species results in duplicate Ability entries #1721

Open
TheodoreBrinkman opened this issue Oct 13, 2024 · 2 comments
Open

Re-importing species results in duplicate Ability entries #1721

TheodoreBrinkman opened this issue Oct 13, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@TheodoreBrinkman
Copy link

TheodoreBrinkman commented Oct 13, 2024

When re-importing species, most (but not all) of the Ability entries end up being duplicated. I discovered this when importing a homebrew Miraluka species, and trying to figure out what was going on. (That's a different issue I'll create.)

I've been looking at the files, but haven't figured out what's unique about the entries that don't duplicate.
(Darkvision on Arkanians, for example)

Steps to replicate:

  1. Import the OggDude zip file normally.
  2. Check a species to see the abilities.
  3. Import the OggDude zip file again.
  4. Check the same species to see the abilities duplicated.

What should happen:
Abilities should not be duplicated.
Abilities that don't exist in the newly imported species file(s) should be removed from the species.
Abilities with a matching name should be updated.
Abilities that didn't previously exist should be added.

@TheodoreBrinkman TheodoreBrinkman added the bug Something isn't working label Oct 13, 2024
@Sasmira
Copy link
Contributor

Sasmira commented Oct 14, 2024

Hello Hello,

I have exactly the same problem !
in addition, would it also be possible to add a “select all” button in oggdude import window please ?

S.

@wrycu wrycu added this to the 1.904 milestone Nov 7, 2024
@wrycu
Copy link
Collaborator

wrycu commented Nov 7, 2024

@Sasmira it's a reasonable request. Please create a new issue for it, rather than adding it on to an existing bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants