Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titles #158

Open
ccstan99 opened this issue Aug 23, 2023 · 1 comment
Open

Fix titles #158

ccstan99 opened this issue Aug 23, 2023 · 1 comment

Comments

@ccstan99
Copy link
Collaborator

Strip newlines from titles. Also consider stripping non-alphanumeric chars from the title and "uncase" (all lowercase) when making hash_ids to catch more duplicates.

@Thomas-Lemoine
Copy link
Collaborator

so there are two ways where changes can be made:

  • article.title
  • article.generate_id_string()
    do you mean that strip new_lines modifies article.title, meaning the displayed article changes, whereas strip non-alphanum and uncase happen in article.generate_id_string(), meaning it won't affect how it's displayed later on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Discussion
Development

No branches or pull requests

2 participants