feat: paragraphs element enclosure. (IMPARTIAL) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
reviewed
Jan 11, 2024
There was a problem hiding this comment.
I don't like how this adds extra complexity - if possible it would be best to avoid HTML in the markdown. I'm not sure how possible it is to do this without deep hackery, in which case it would seem better to just say that this is a limitation of the system, rather than add more hacks
| @@ -266,7 +277,8 @@ export const parseParagraph = (documentContext) => (paragraph) => { | |||
| leadingSpace + | |||
| itemMarker + | |||
| prefix + | |||
| md.join("").replaceAll("\n", "\n" + leadingSpace) | |||
| md.join("").replaceAll("\n", "\n" + leadingSpace)+ | |||
There was a problem hiding this comment.
this will only work with one newline - if there are more, it will result in somwthing like:
<div>
bla bla bla
<div>ble ble ble
<div>bla bla bla
</div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.