-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slider for updating the column and row for the Color Grid #4
Comments
Hey bro, can I pick this up. Also your code is using class based components I you don't mind can I change them to functional based component |
Hey I can add the slider for updating the columns and row for the color grid. |
I think they should be controllable seperately, but if you find single control better, then you may implement that. Should I assign this to you? |
Yeah sure |
You may convert it to functional components, i created it some time ago, and i don't remember why I picked class based |
I can continue it in class base also. As you wise @SscSPs |
@webcoderspeed please create an issue for "functional components" and you can work on that, i suppose this can be done by @00sukhjeet00 |
Yeah sure not an issue. Thanks assigning |
@SscSPs Should I start working with class based or wait for @webcoderspeed to create functional based component and then start working on slider |
I have created a issue #11 for converting class to functional components |
Awesome! You two please discuss with each other based on when you want to work on your tasks to clarify the timelines, @00sukhjeet00 @webcoderspeed whichever one takes less time can be done earlier and the other person can start after that or tomorrow |
On second thought, i think component conversion should be first, to have less work for conversion |
@00sukhjeet00 let me first complete the conversion from class based to functional and then after that |
Okay, @webcoderspeed Thanks for conformation. |
#11 @00sukhjeet00 bro you can proceed after the merge |
Yeah sure |
@00sukhjeet00 #11 was merged some time ago, you can work on this as you get time |
Okay @SscSPs |
The grid currently have fixed rows and column count,
we should add sliders for them so user can control it.
The text was updated successfully, but these errors were encountered: