From deb771dcc04720db151c4e12f6a6ea20aed95c90 Mon Sep 17 00:00:00 2001 From: Brandon Shearin Date: Fri, 22 Nov 2024 10:11:22 -0500 Subject: [PATCH 1/3] update docs? dont know if this worked --- .../openapi/src/paths/attack-paths.domains.id.details.yaml | 6 +----- packages/go/openapi/src/schemas/model.list-finding.yaml | 6 ------ 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml b/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml index 7fd539d196..4164185b4a 100644 --- a/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml +++ b/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml @@ -177,7 +177,7 @@ get: AcceptedUntil: "2024-08-28T21:21:40.845Z", ImpactPercentage: 12, ImpactCount: 2, - ExposurePercentage: 24, + ExposurePercentage: .24, ExposureCount: 4, Severity: 'high', Accepted: true, @@ -262,8 +262,6 @@ get: accepted_until: "2024-08-28T21:42:18.844Z", ImpactPercentage: 12, ImpactCount: 2, - ExposurePercentage: 24, - ExposureCount: 4, Severity: 'high', Accepted: true } @@ -296,8 +294,6 @@ get: accepted_until: "2024-08-28T21:42:18.844Z", ImpactPercentage: 0, ImpactCount: 0, - ExposurePercentage: 0, - ExposureCount: 0, Severity: '', Accepted: true } diff --git a/packages/go/openapi/src/schemas/model.list-finding.yaml b/packages/go/openapi/src/schemas/model.list-finding.yaml index f283768896..c767525ba0 100644 --- a/packages/go/openapi/src/schemas/model.list-finding.yaml +++ b/packages/go/openapi/src/schemas/model.list-finding.yaml @@ -40,12 +40,6 @@ allOf: ImpactCount: type: integer format: int64 - ExposurePercentage: - type: number - format: double - ExposureCount: - type: integer - format: int64 Severity: type: string enum: From 931dbf634f4b5b5eba7d7115e4387aa85a408f14 Mon Sep 17 00:00:00 2001 From: Brandon Shearin Date: Fri, 22 Nov 2024 10:22:09 -0500 Subject: [PATCH 2/3] openapi updated for list findings --- packages/go/openapi/doc/openapi.json | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/packages/go/openapi/doc/openapi.json b/packages/go/openapi/doc/openapi.json index 9b608944b4..1d87a80b68 100644 --- a/packages/go/openapi/doc/openapi.json +++ b/packages/go/openapi/doc/openapi.json @@ -12602,7 +12602,7 @@ "AcceptedUntil": "2024-08-28T21:21:40.845Z", "ImpactPercentage": 12, "ImpactCount": 2, - "ExposurePercentage": 24, + "ExposurePercentage": 0.24, "ExposureCount": 4, "Severity": "high", "Accepted": true @@ -12691,8 +12691,6 @@ "accepted_until": "2024-08-28T21:42:18.844Z", "ImpactPercentage": 12, "ImpactCount": 2, - "ExposurePercentage": 24, - "ExposureCount": 4, "Severity": "high", "Accepted": true } @@ -12727,8 +12725,6 @@ "accepted_until": "2024-08-28T21:42:18.844Z", "ImpactPercentage": 0, "ImpactCount": 0, - "ExposurePercentage": 0, - "ExposureCount": 0, "Severity": "", "Accepted": true } @@ -15930,14 +15926,6 @@ "type": "integer", "format": "int64" }, - "ExposurePercentage": { - "type": "number", - "format": "double" - }, - "ExposureCount": { - "type": "integer", - "format": "int64" - }, "Severity": { "type": "string", "enum": [ From bb88fc0bb419cba7682639a0dbf5e01d309c4918 Mon Sep 17 00:00:00 2001 From: Alyx Holms Date: Mon, 25 Nov 2024 13:52:07 -0700 Subject: [PATCH 3/3] chore: prepare-for-codereview run --- cmd/api/src/api/v2/auth/saml.go | 2 +- cmd/api/src/database/db.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/api/src/api/v2/auth/saml.go b/cmd/api/src/api/v2/auth/saml.go index 5f2da6cc92..86596c1374 100644 --- a/cmd/api/src/api/v2/auth/saml.go +++ b/cmd/api/src/api/v2/auth/saml.go @@ -31,7 +31,7 @@ import ( "github.com/specterops/bloodhound/log" "github.com/specterops/bloodhound/mediatypes" "github.com/specterops/bloodhound/src/api" - "github.com/specterops/bloodhound/src/api/v2" + v2 "github.com/specterops/bloodhound/src/api/v2" "github.com/specterops/bloodhound/src/auth" "github.com/specterops/bloodhound/src/ctx" "github.com/specterops/bloodhound/src/model" diff --git a/cmd/api/src/database/db.go b/cmd/api/src/database/db.go index 1dcd20feec..b324a00b33 100644 --- a/cmd/api/src/database/db.go +++ b/cmd/api/src/database/db.go @@ -124,7 +124,6 @@ type Database interface { DeleteAuthSecret(ctx context.Context, authSecret model.AuthSecret) error InitializeSecretAuth(ctx context.Context, adminUser model.User, authSecret model.AuthSecret) (model.Installation, error) - // SSO SSOProviderData OIDCProviderData