Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create ForceChangePassword edges against disabled users #248

Open
JonasBK opened this issue Nov 29, 2023 · 0 comments
Open

Don't create ForceChangePassword edges against disabled users #248

JonasBK opened this issue Nov 29, 2023 · 0 comments
Labels
enhancement New feature or request ticketed Ticket has been created internally for tracking

Comments

@JonasBK
Copy link
Collaborator

JonasBK commented Nov 29, 2023

If you have ForceChangePassword on a user, you can fully compromise the user by resetting the password and logging in as the user. However, if the user is disabled, you cannot log in. You can enable the user if you have GenericAll on the user, but not with only ForceChangePassword. So the attack path is broken.

We should find a better way to handle inbound edges on disabled users, in the cases where the edge permission does not allow the attacker to enable the user.

Stopping from generating edges like ForceChangePassword on disabled users would not be a good solution, as we still want users to be able to audit all ForceChangePassword permissions.

@JonasBK JonasBK added enhancement New feature or request triage This issue requires triaging labels Nov 29, 2023
@StephenHinck StephenHinck removed the triage This issue requires triaging label Feb 29, 2024
@StephenHinck StephenHinck changed the title Better way of handling inbound edges on disabled users Don't create ForceChangePassword edges against disabled users Feb 29, 2024
@slokie-so slokie-so added the ticketed Ticket has been created internally for tracking label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ticketed Ticket has been created internally for tracking
Projects
None yet
Development

No branches or pull requests

3 participants