Skip to content

Commit

Permalink
chore: prep review changes (#988)
Browse files Browse the repository at this point in the history
  • Loading branch information
urangel authored Nov 27, 2024
1 parent 70849cc commit ff2a2d5
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/api/src/model/samlprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var (
SAMLRootURIVersion1 SAMLRootURIVersion = 1
SAMLRootURIVersion2 SAMLRootURIVersion = 2

SAMLRootURIVersionMap = map[SAMLRootURIVersion]string {
SAMLRootURIVersionMap = map[SAMLRootURIVersion]string{
SAMLRootURIVersion1: "/api/v1/login/saml",
SAMLRootURIVersion2: "/api/v2/sso",
}
Expand Down Expand Up @@ -147,7 +147,7 @@ func (s SAMLProvider) GetSAMLUserPrincipalNameFromAssertion(assertion *saml.Asse

func (s *SAMLProvider) FormatSAMLProviderURLs(hostUrl url.URL) {
root := hostUrl
root.Path = path.Join(SAMLRootURIVersionMap[s.RootURIVersion], s.Name)
root.Path = path.Join(SAMLRootURIVersionMap[s.RootURIVersion], s.Name)

// To preserve existing IDP configurations, existing saml providers still use the old acs endpoint which redirects to the new callback handler
switch s.RootURIVersion {
Expand Down
16 changes: 16 additions & 0 deletions packages/go/analysis/post_integration_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
// Copyright 2024 Specter Ops, Inc.
//
// Licensed under the Apache License, Version 2.0
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// SPDX-License-Identifier: Apache-2.0

//go:build serial_integration
// +build serial_integration

Expand Down
1 change: 1 addition & 0 deletions packages/go/graphschema/ad/ad.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/go/graphschema/azure/azure.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/go/graphschema/common/common.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ff2a2d5

Please sign in to comment.