From fa4cf8cd16ff40ddfe3f36533766f9cb5364aaf2 Mon Sep 17 00:00:00 2001
From: Elijah Brown <elijah@ad7zj.net>
Date: Mon, 18 Nov 2024 16:15:28 -0700
Subject: [PATCH] BED 4970 (#960)

* Renamed "search_query" to "query" on the /api/v2/graph-search endpoint. This matches what the code expects.

Changed "start_node" and "end_node" to string type on the /api/v2/graphs/shortest-path endpoint. This matches what the code expects.

* Check in updated openapi.json file after running just gen-spec

* Removed "Finding" parameter from the /api/v2/domains/{domain_id}/details endpoint.
Updated openapi.json file using just gen-spec
---
 packages/go/openapi/doc/openapi.json             | 16 +++-------------
 .../paths/attack-paths.domains.id.details.yaml   |  5 -----
 .../go/openapi/src/paths/graph.graph-search.yaml |  2 +-
 .../src/paths/graph.graphs.shortest-path.yaml    |  6 ++----
 4 files changed, 6 insertions(+), 23 deletions(-)

diff --git a/packages/go/openapi/doc/openapi.json b/packages/go/openapi/doc/openapi.json
index 3fed53013b..9b608944b4 100644
--- a/packages/go/openapi/doc/openapi.json
+++ b/packages/go/openapi/doc/openapi.json
@@ -4152,7 +4152,7 @@
         ],
         "parameters": [
           {
-            "name": "search_query",
+            "name": "query",
             "description": "Search query",
             "in": "query",
             "required": true,
@@ -4232,8 +4232,7 @@
             "in": "query",
             "required": true,
             "schema": {
-              "type": "integer",
-              "format": "int32"
+              "type": "string"
             }
           },
           {
@@ -4242,8 +4241,7 @@
             "in": "query",
             "required": true,
             "schema": {
-              "type": "integer",
-              "format": "int32"
+              "type": "string"
             }
           },
           {
@@ -12459,14 +12457,6 @@
               "$ref": "#/components/schemas/api.params.predicate.filter.string"
             }
           },
-          {
-            "name": "Finding",
-            "deprecated": true,
-            "in": "query",
-            "schema": {
-              "$ref": "#/components/schemas/api.params.predicate.filter.string"
-            }
-          },
           {
             "name": "domain_sid",
             "in": "query",
diff --git a/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml b/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml
index c3907c7591..7fd539d196 100644
--- a/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml
+++ b/packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml
@@ -85,11 +85,6 @@ get:
       in: query
       schema:
         $ref: './../schemas/api.params.predicate.filter.string.yaml'
-    - name: Finding
-      deprecated: true
-      in: query
-      schema:
-        $ref: './../schemas/api.params.predicate.filter.string.yaml'
     - name: domain_sid
       in: query
       schema:
diff --git a/packages/go/openapi/src/paths/graph.graph-search.yaml b/packages/go/openapi/src/paths/graph.graph-search.yaml
index dfe2af6111..c1e0f83ae1 100644
--- a/packages/go/openapi/src/paths/graph.graph-search.yaml
+++ b/packages/go/openapi/src/paths/graph.graph-search.yaml
@@ -25,7 +25,7 @@ get:
     - Community
     - Enterprise
   parameters:
-    - name: search_query
+    - name: query
       description: Search query
       in: query
       required: true
diff --git a/packages/go/openapi/src/paths/graph.graphs.shortest-path.yaml b/packages/go/openapi/src/paths/graph.graphs.shortest-path.yaml
index 7f54e7ade3..d36190168b 100644
--- a/packages/go/openapi/src/paths/graph.graphs.shortest-path.yaml
+++ b/packages/go/openapi/src/paths/graph.graphs.shortest-path.yaml
@@ -30,15 +30,13 @@ get:
       in: query
       required: true
       schema:
-        type: integer
-        format: int32
+        type: string
     - name: end_node
       description: The end node objectId
       in: query
       required: true
       schema:
-        type: integer
-        format: int32
+        type: string
     - name: relationship_kinds
       in: query
       schema: