From 794e279719b07ed65e2132c153f5513f452470cf Mon Sep 17 00:00:00 2001
From: Ben Waples <bwaples@specterops.io>
Date: Wed, 27 Nov 2024 13:53:45 -0800
Subject: [PATCH] fix: flashing modal display

---
 .../src/components/UpsertOIDCProviderDialog.tsx           | 4 ++--
 .../src/views/SSOConfiguration/SSOConfiguration.tsx       | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/javascript/bh-shared-ui/src/components/UpsertOIDCProviderDialog.tsx b/packages/javascript/bh-shared-ui/src/components/UpsertOIDCProviderDialog.tsx
index 226f1c230..3cda8ded0 100644
--- a/packages/javascript/bh-shared-ui/src/components/UpsertOIDCProviderDialog.tsx
+++ b/packages/javascript/bh-shared-ui/src/components/UpsertOIDCProviderDialog.tsx
@@ -18,7 +18,7 @@ import { Dialog, DialogTitle } from '@mui/material';
 import { SSOProvider, UpsertOIDCProviderRequest } from 'js-client-library';
 import UpsertOIDCProviderForm from './UpsertOIDCProviderForm';
 
-const UpsertSAMLProviderDialog: React.FC<{
+const UpsertOIDCProviderDialog: React.FC<{
     open: boolean;
     error?: string;
     oldSSOProvider?: SSOProvider;
@@ -46,4 +46,4 @@ const UpsertSAMLProviderDialog: React.FC<{
     );
 };
 
-export default UpsertSAMLProviderDialog;
+export default UpsertOIDCProviderDialog;
diff --git a/packages/javascript/bh-shared-ui/src/views/SSOConfiguration/SSOConfiguration.tsx b/packages/javascript/bh-shared-ui/src/views/SSOConfiguration/SSOConfiguration.tsx
index 295ccc338..cfcdd4091 100644
--- a/packages/javascript/bh-shared-ui/src/views/SSOConfiguration/SSOConfiguration.tsx
+++ b/packages/javascript/bh-shared-ui/src/views/SSOConfiguration/SSOConfiguration.tsx
@@ -17,7 +17,7 @@
 import { faSearch } from '@fortawesome/free-solid-svg-icons';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { Box, Grid, Paper, TextField, Typography, useTheme } from '@mui/material';
-import { SSOProvider, UpsertSAMLProviderFormInputs, UpsertOIDCProviderRequest } from 'js-client-library';
+import { SSOProvider, UpsertOIDCProviderRequest, UpsertSAMLProviderFormInputs } from 'js-client-library';
 import { ChangeEvent, FC, useMemo, useState } from 'react';
 import { useMutation, useQuery } from 'react-query';
 import {
@@ -117,7 +117,7 @@ const SSOConfiguration: FC = () => {
     const closeDialog = () => {
         setUpsertProviderError('');
         setDialogOpen('');
-        setSSOProviderIdToDeleteOrUpdate(undefined);
+        setTimeout(() => setSSOProviderIdToDeleteOrUpdate(undefined), 500);
     };
 
     const onClickSSOProvider = (ssoProviderId: SSOProvider['id']) => {
@@ -290,14 +290,14 @@ const SSOConfiguration: FC = () => {
             </PageWithTitle>
             <UpsertSAMLProviderDialog
                 open={dialogOpen === 'SAML'}
-                oldSSOProvider={dialogOpen === 'SAML' ? selectedSSOProviderToUpdate : undefined}
+                oldSSOProvider={selectedSSOProviderToUpdate}
                 error={upsertProviderError}
                 onClose={closeDialog}
                 onSubmit={upsertSAMLProvider}
             />
             <UpsertOIDCProviderDialog
                 open={dialogOpen === 'OIDC'}
-                oldSSOProvider={dialogOpen === 'OIDC' ? selectedSSOProviderToUpdate : undefined}
+                oldSSOProvider={selectedSSOProviderToUpdate}
                 error={upsertProviderError}
                 onClose={closeDialog}
                 onSubmit={upsertOIDCProvider}